Multiple param patch#373
Open
AndrewGiddings-at-BankCheck wants to merge 2 commits intotaskadapter:masterfrom
Open
Multiple param patch#373AndrewGiddings-at-BankCheck wants to merge 2 commits intotaskadapter:masterfrom
AndrewGiddings-at-BankCheck wants to merge 2 commits intotaskadapter:masterfrom
Conversation
Suggested fix for issues taskadapter#360 and taskadapter#339. Preserves duplicate params with names ending in `[]` (needed for free-form Redmine queries), while still removing others.
Add unit tests for URIConfigurator.dedup().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested fix for issues #360 and #339.
This preserves duplicate request params with names ending in
[](which are needed if the request has multiple free-form Redmine queries), while still removing other duplicates.(I'm not sure why duplicates are a problem in the first place, but presumably there was some reason for their removal…)
I've added unit tests for the new
dedup()function; all the existing URIConfigurator tests still pass, too. I wasn't able to run most of the other unit tests, as they connect tohttp://dev.taskadapter.com:8097which isn't reachable, and I don't know of an alternative test server. But these changes are localised and shouldn't affect anything else.Also, I've tested this in our own application, and confirmed that it fixes the multiple-queries issue, and doesn't seem to break anything else.